Adding Glance Inner Radius Snipper #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
riggaroo
reviewed
Mar 5, 2025
| val resources = LocalContext.current.resources | ||
| // get dimension in float (without rounding). | ||
| val px = resources.getDimension(android.R.dimen.system_app_widget_background_radius) | ||
| val widgetBackgroundRadiusDpValue = px / resources.displayMetrics.density |
Collaborator
There was a problem hiding this comment.
Can you use the helper function:
val widgetBackgroundRadiusDpValue = with(LocalDensity.current){ intValue.toDp() }
Contributor
Author
There was a problem hiding this comment.
LocalDensity isn't available during a glance composition. This is a glance snippet so the code would crash.
riggaroo
reviewed
Mar 5, 2025
compose/snippets/src/main/java/com/example/compose/snippets/glance/GlanceSnippets.kt
Outdated
Show resolved
Hide resolved
riggaroo
reviewed
Mar 5, 2025
compose/snippets/src/main/java/com/example/compose/snippets/glance/GlanceSnippets.kt
Outdated
Show resolved
Hide resolved
secondsun
force-pushed
the
glance_inner_radius
branch
from
6187d01 to
dc43d2b
Compare
riggaroo
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a snippet for Glance Inner Radius